Skip to content

Fix '.format()' issue with 'find' {} placeholder (double braces addition), escaped slash and reordering of arguments #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbuncic merged 5 commits into from
Jul 21, 2026
Merged

Fix '.format()' issue with 'find' {} placeholder (double braces addition), escaped slash and reordering of arguments #104

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aec2218
fix: add double brace fix to find
Apr 21, 2026
c4de543
fix: removed escaped slash in find (bash)
Apr 23, 2026
d8a8c1c
misc: warning on find argument order (global options)
Apr 23, 2026
a6ee5e6
misc: fix warning on other find cmd
Apr 23, 2026
6d96804
misc: reorder arguments for find
Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bits_helpers/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ def fetch_symlinks(self, spec) -> None:
# Exit without error in case we do not have any package published
test -d "{remote_store}/{cvmfs_architecture}/Packages/{package}" || exit 0
mkdir -p "{workDir}/{links_path}"
for install_path in $(find "{remote_store}/{cvmfs_architecture}/Packages/{package}" -type d -mindepth 1 -maxdepth 1); do
for install_path in $(find "{remote_store}/{cvmfs_architecture}/Packages/{package}" -mindepth 1 -maxdepth 1 -type d); do
full_version="${{install_path##*/}}"
tarball={package}-$full_version.{architecture}.tar.gz
pkg_hash=$(cat "${{install_path}}/.build-hash" || jq -r '.package.hash' <${{install_path}}/.meta.json)
Expand All @@ -695,7 +695,7 @@ def fetch_symlinks(self, spec) -> None:
# Create the dummy tarball, if it does not exists
test -f "{workDir}/{architecture}/store/${{pkg_hash:0:2}}/$pkg_hash/$tarball" && continue
mkdir -p "{workDir}/INSTALLROOT/$pkg_hash/{architecture}/{package}"
find "{remote_store}/{cvmfs_architecture}/Packages/{package}/$full_version" ! -name etc -maxdepth 1 -mindepth 1 -exec ln -sf {} "{workDir}/INSTALLROOT/$pkg_hash/{architecture}/{package}/" \\;
find "{remote_store}/{cvmfs_architecture}/Packages/{package}/$full_version" -mindepth 1 -maxdepth 1 ! -name etc -exec ln -sf {{}} "{workDir}/INSTALLROOT/$pkg_hash/{architecture}/{package}/" \;
cp -fr "{remote_store}/{cvmfs_architecture}/Packages/{package}/$full_version/etc" "{workDir}/INSTALLROOT/$pkg_hash/{architecture}/{package}/etc"
mkdir -p "{workDir}/TARS/{architecture}/store/${{pkg_hash:0:2}}/$pkg_hash"
tar -C "{workDir}/INSTALLROOT/$pkg_hash" -czf "{workDir}/TARS/{architecture}/store/${{pkg_hash:0:2}}/$pkg_hash/$tarball" .
Expand Down
Loading