fix: preserve insertion order of object names#409
Merged
Conversation
The get_object_id_to_names query used list(set(...)) to deduplicate names, which produces non-deterministic order due to Python hash randomization. This caused Bright Star catalog entries (and others with multiple names) to display names in inconsistent order, varying between runs — e.g. "Str3 Alpha Crucis, Acrux" instead of the expected "Str3 Acrux, Alpha Crucis". Use dict.fromkeys() to deduplicate while preserving order, and add ORDER BY rowid to the query so SQLite returns names in insertion order. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
brickbots
pushed a commit
that referenced
this pull request
Apr 18, 2026
The get_object_id_to_names query used list(set(...)) to deduplicate names, which produces non-deterministic order due to Python hash randomization. This caused Bright Star catalog entries (and others with multiple names) to display names in inconsistent order, varying between runs — e.g. "Str3 Alpha Crucis, Acrux" instead of the expected "Str3 Acrux, Alpha Crucis". Use dict.fromkeys() to deduplicate while preserving order, and add ORDER BY rowid to the query so SQLite returns names in insertion order. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_object_id_to_namesusedlist(set(...))to deduplicate, which is non-deterministic due to Python hash randomization. Also, the underlying SELECT had noORDER BY.dict.fromkeys()to dedupe while preserving insertion order, and addORDER BY rowidto guarantee SQLite returns rows in insertion order.Reported by waterman480 on Discord — order of common vs. Latin names was flipping between runs on v2.4 and v2.5.
Test plan
🤖 Generated with Claude Code