Skip to content

fix: preserve insertion order of object names #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brickbots merged 1 commit into from
Apr 18, 2026
Merged

fix: preserve insertion order of object names #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/PiFinder/db/objects_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def get_object_id_to_names(self) -> DefaultDict[int, List[str]]:
logging.info("Starting get_object_id_to_names query...")

query_start = time.time()
self.cursor.execute("SELECT object_id, common_name FROM names;")
self.cursor.execute("SELECT object_id, common_name FROM names ORDER BY rowid;")
results = self.cursor.fetchall()
query_time = time.time() - query_start
logging.info(
Expand All @@ -206,7 +206,7 @@ def get_object_id_to_names(self) -> DefaultDict[int, List[str]]:
for object_id, common_name in results:
name_dict[object_id].append(common_name.strip())
for object_id in name_dict:
name_dict[object_id] = list(set(name_dict[object_id]))
name_dict[object_id] = list(dict.fromkeys(name_dict[object_id]))
process_time = time.time() - process_start
logging.info(
f"Processing took {process_time:.2f}s, created {len(name_dict)} object entries"
Expand Down
Loading