-
Notifications
You must be signed in to change notification settings - Fork 1
feat: scaffold GARM 12-factor charm with ROCK image (ISD-5718) #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yanksyoon
wants to merge
29
commits into
main
Choose a base branch
from
feat/isd-5718-garm-charm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
535b2ee
feat: add GARM ROCK image spec and build script
yanksyoon 90d439a
fix: correct GARM build path and add SQLite build tags
yanksyoon 204e04e
feat: scaffold garm-operator charm metadata and tooling
yanksyoon 503af21
fix: correct garm-operator scaffold issues
yanksyoon b728d12
feat: add GARM TOML rendering function with tests
yanksyoon f842467
fix: address code quality issues in TOML rendering
yanksyoon c61ac1b
feat: add GarmCharm class with secrets and Pebble integration
yanksyoon 54c4ed7
fix: handle missing secret on non-leader units in restart()
yanksyoon a11a114
feat: add garm-operator Terraform module
yanksyoon 872fc56
fix: update copyright year to 2026
yanksyoon a490782
fix: align GARM config and DB paths with upstream defaults
yanksyoon 9f1592d
fix: move --only-binary=pluggy from requirements.txt to tox unit deps
yanksyoon e898977
feat: add GARM charm integration tests
yanksyoon 2a00058
ci: add GARM charm to lint/unit matrix, publish workflow, and integra…
yanksyoon 02c909d
ci: comment out garm from publish matrix until charm is functional
yanksyoon 680a3d1
Merge branch 'main' into feat/isd-5718-garm-charm
yanksyoon f983a25
fix: remove --only-binary=pluggy from tox unit deps
yanksyoon ca08dce
chore: remove unused pytest import and fix blank line
yanksyoon 0a6cc23
docs: add changelog entry for GARM charm scaffold
yanksyoon 18df9e8
fix: use go/1.26/stable and GOTOOLCHAIN=local for ROCK build
yanksyoon 091d7e2
refactor: remove db-passphrase SQLite encryption placeholder
yanksyoon 6b0aaa0
Potential fix for pull request finding
yanksyoon da290da
chore: remove unused postgresql_k8s charm lib
yanksyoon 8b4c5f6
refactor: address PR review comments
yanksyoon 1d99898
revert: restore provider section and OPENSTACK_PROVIDER_BINARY
yanksyoon 52b1cc5
chore: bump build-base to ubuntu@26.04 (Resolute)
yanksyoon 156d8c0
revert: revert build-base to ubuntu@24.04
yanksyoon 47b6659
charms/garm: rename Charmhub charm name to garm
yanksyoon 07c8c50
ci: trigger CI run
yanksyoon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # | ||
| # Copyright 2026 Canonical Ltd. | ||
| # See LICENSE file for licensing details. | ||
| # | ||
|
|
||
| export ROCKCRAFT_ENABLE_EXPERIMENTAL_EXTENSIONS=true | ||
|
|
||
| ln -s ./garm-rockcraft.yaml ./rockcraft.yaml | ||
| rockcraft clean | ||
| rockcraft pack | ||
| rm ./rockcraft.yaml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| venv/ | ||
|
florentianayuwono marked this conversation as resolved.
|
||
| build/ | ||
| *.charm | ||
| .tox/ | ||
| .coverage | ||
| __pycache__/ | ||
| *.py[cod] | ||
| .idea | ||
| .vscode/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Copyright 2026 Canonical Ltd. | ||
| # See LICENSE file for licensing details. | ||
|
|
||
| name: garm | ||
|
|
||
| type: charm | ||
|
|
||
| base: ubuntu@24.04 | ||
|
|
||
| platforms: | ||
| amd64: | ||
|
|
||
| summary: GARM — GitHub Actions Runner Manager charm. | ||
|
|
||
| description: | | ||
| Deploys and manages GARM (GitHub Actions Runner Manager) using the | ||
| 12-factor app framework with SQLite storage and an OpenStack runner provider. | ||
|
|
||
| extensions: | ||
| - go-framework | ||
|
|
||
| config: | ||
| options: | ||
| garm-listen-address: | ||
| type: string | ||
| default: "0.0.0.0" | ||
| description: Address GARM API server listens on. | ||
| garm-listen-port: | ||
| type: int | ||
| default: 9997 | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. garm service port found in test: https://raw.githubusercontent.com/cloudbase/garm/v0.2.1/testdata/config.toml |
||
| description: Port GARM API server listens on. | ||
| garm-db-path: | ||
| type: string | ||
| default: "/etc/garm/garm.db" | ||
| description: Path to the SQLite database file. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.