Conversation
Reduce the default request context to headers, ip and library, and remove the now-unused Castle::ClientId::Extract service plus the cookies plumbing in Castle::Context::GetDefault. The dropped context fields (client_id, active, user_agent, locale) are already derivable from headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Some housekeeping around the default request context we build in
Castle::Context::GetDefault. It now carries justheaders,ipandlibrary— theclient_id,active,user_agentandlocalefields were redundant since that data already travels inheaders, so I've trimmed them along with the internalCastle::ClientId::Extractservice that backedclient_id.Shipping as a patch (
9.1.0→9.1.1): this is housekeeping on internal/derivable data, not a feature or an intentional API change.Changes
{ headers:, ip:, library: }.Castle::ClientId::Extractservice (class + spec) and itslib/castle.rbrequire.Castle::Context::GetDefault#initializeto take onlyrequest(thecookiesargument and unused ivars are gone) and updatedContext::Prepareaccordingly.VERSIONto9.1.1, refreshedGemfile.lock, added the CHANGELOG entry.Known limitations
cookiesoption onCastle::Client.from_request/Castle::Context::Prepare.callis now a no-op — its only consumer was the removed ClientId service. I've left the signature untouched to avoid a gratuitous public API change; happy to drop it in a follow-up if we'd rather not carry a dead option.