Release 9.1.1: slim down default context, drop ClientId service

CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 9.1.1
+
+**Housekeeping:**
+
+- Slim down the default request context to `headers`, `ip` and `library`; the remaining data is already available via `headers`.
+- Remove the internal `Castle::ClientId::Extract` service and the now-unused `cookies` plumbing in `Castle::Context::GetDefault`.
+
 ## 9.1.0
 
 **Enhancements:**

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    castle-rb (9.1.0)
+    castle-rb (9.1.1)
       base64 (~> 0.2)
 
 GEM

lib/castle.rb

@@ -78,7 +78,6 @@
   castle/headers/format
   castle/headers/extract
   castle/secure_mode
-  castle/client_id/extract
   castle/ips/extract
   castle/core/get_connection
   castle/core/process_response

lib/castle/context/get_default.rb

@@ -3,50 +3,21 @@
 module Castle
   module Context
     class GetDefault
-      def initialize(request, cookies = nil)
+      def initialize(request)
         @pre_headers = Castle::Headers::Filter.new(request).call
-        @cookies = cookies || request.cookies
-        @request = request
       end
 
       def call
-        {
-          client_id: client_id,
-          active: true,
-          headers: headers,
-          ip: ip,
-          library: {
-            name: 'castle-rb',
-            version: Castle::VERSION
-          }
-        }.tap do |result|
-          result[:locale] = locale if locale
-          result[:user_agent] = user_agent if user_agent
-        end
+        { headers: headers, ip: ip, library: { name: 'castle-rb', version: Castle::VERSION } }
       end
 
       private
 
-      # @return [String]
-      def locale
-        @pre_headers['Accept-Language']
-      end
-
-      # @return [String]
-      def user_agent
-        @pre_headers['User-Agent']
-      end
-
       # @return [String]
       def ip
         Castle::IPs::Extract.new(@pre_headers).call
       end
 
-      # @return [String]
-      def client_id
-        Castle::ClientId::Extract.new(@pre_headers, @cookies).call
-      end
-
       # formatted and filtered headers
       # @return [Hash]
       def headers

lib/castle/context/prepare.rb

@@ -9,7 +9,7 @@ class << self
         # @param options [Hash]
         # @return [Hash]
         def call(request, options = {})
-          default_context = Castle::Context::GetDefault.new(request, options[:cookies]).call
+          default_context = Castle::Context::GetDefault.new(request).call
           Castle::Context::Merge.call(default_context, options[:context])
         end
       end

lib/castle/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Castle
-  VERSION = '9.1.0'
+  VERSION = '9.1.1'
 end

spec/lib/castle/client_spec.rb

@@ -20,19 +20,7 @@
   let(:client_with_no_timestamp) { described_class.new(context: request_to_context) }
 
   let(:headers) { { 'Content-Length': '0', 'User-Agent': ua, 'X-Forwarded-For': ip.to_s, Cookie: true } }
-  let(:context) do
-    {
-      client_id: 'abcd',
-      active: true,
-      user_agent: ua,
-      headers: headers,
-      ip: ip,
-      library: {
-        name: 'castle-rb',
-        version: '2.2.0'
-      }
-    }
-  end
+  let(:context) { { headers: headers, ip: ip, library: { name: 'castle-rb', version: '2.2.0' } } }
 
   let(:time_now) { Time.now }
   let(:time_auto) { time_now.utc.iso8601(3) }

spec/lib/castle/context/get_default_spec.rb

@@ -1,18 +1,17 @@
 # frozen_string_literal: true
 
 RSpec.describe Castle::Context::GetDefault do
-  subject { described_class.new(request, nil) }
+  subject { described_class.new(request) }
 
   let(:ip) { '1.2.3.4' }
-  let(:client_id) { 'abcd' }
 
   let(:env) do
     Rack::MockRequest.env_for(
       '/',
       'HTTP_X_FORWARDED_FOR' => ip,
       'HTTP_ACCEPT_LANGUAGE' => 'en',
       'HTTP_USER_AGENT' => 'test',
-      'HTTP_COOKIE' => "__cid=#{client_id};other=efgh",
+      'HTTP_COOKIE' => 'other=efgh',
       'HTTP_CONTENT_LENGTH' => '0'
     )
   end
@@ -31,11 +30,8 @@
 
   before { stub_const('Castle::VERSION', version) }
 
-  it { expect(default_context[:active]).to be(true) }
   it { expect(default_context[:headers]).to eql(result_headers) }
   it { expect(default_context[:ip]).to eql(ip) }
-  it { expect(default_context[:client_id]).to eql(client_id) }
   it { expect(default_context[:library][:name]).to eql('castle-rb') }
   it { expect(default_context[:library][:version]).to eql(version) }
-  it { expect(default_context[:user_agent]).to eql('test') }
 end

spec/lib/castle/context/prepare_spec.rb

@@ -14,19 +14,7 @@
     )
   end
   let(:request) { Rack::Request.new(env) }
-  let(:context) do
-    {
-      client_id: 'abcd',
-      active: true,
-      user_agent: ua,
-      headers: headers,
-      ip: ip,
-      library: {
-        name: 'castle-rb',
-        version: '6.0.0'
-      }
-    }
-  end
+  let(:context) { { headers: headers, ip: ip, library: { name: 'castle-rb', version: '6.0.0' } } }
 
   let(:headers) { { 'Content-Length': '0', 'User-Agent': ua, 'X-Forwarded-For': ip.to_s, Cookie: true } }
 
@@ -35,8 +23,6 @@
   describe '#call' do
     subject(:generated) { described_class.call(request) }
 
-    context 'when active true' do
-      it { is_expected.to eql(context) }
-    end
+    it { is_expected.to eql(context) }
   end
 end

spec/lib/castle/payload/prepare_spec.rb

@@ -16,19 +16,7 @@
   let(:request) { Rack::Request.new(env) }
 
   let(:headers) { { 'Content-Length': '0', 'User-Agent': ua, 'X-Forwarded-For': ip.to_s, Cookie: true } }
-  let(:context) do
-    {
-      client_id: 'abcd',
-      active: true,
-      user_agent: ua,
-      headers: headers,
-      ip: ip,
-      library: {
-        name: 'castle-rb',
-        version: '2.2.0'
-      }
-    }
-  end
+  let(:context) { { headers: headers, ip: ip, library: { name: 'castle-rb', version: '2.2.0' } } }
 
   let(:time_now) { Time.now }
   let(:time_formatted) { time_now.utc.iso8601(3) }
@@ -45,8 +33,6 @@
   describe '#call' do
     subject(:generated) { described_class.call(payload_options, request) }
 
-    context 'when active true' do
-      it { is_expected.to eql(result) }
-    end
+    it { is_expected.to eql(result) }
   end
 end