Add TUI auth profile login flow#122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Codex Lab is moving toward daily dogfooding with multiple auth accounts. The existing
/loginpicker could switch among previously-created auth profiles, but adding another account still required leaving the TUI and running a shell command. That made the first multi-auth flow feel unfinished and easy to forget during normal use.What Changed
/loginpicker’sAdd login...row actionable by pre-filling/login addin the composer./login add <profile>to validate a new profile name, reject ambiguous names such asdefault, switch to that profile’sauth_home, and start the ChatGPT browser login flow.login_id, surfaces login failure, and records auth-profile metadata only after the post-loginAccountUpdatednotification confirms the app server has reloaded auth.Verification
cargo test -p codex-tui login_slash_commandcargo check -p codex-tui