Add auto-review coordination locks#133
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of #130. Codex Lab needs the durable auto-review store to have the same kind of cross-session coordination foundation that Every Code used: a repo-scoped
review.lockfor ownership and a repo-scopedsnapshot.epochfor detecting stale snapshots after repository mutations.This PR intentionally lands the primitive only. Runtime scheduling integration is deferred to the next #130 slice so the coordination layer can be reviewed and tested on its own.
What Changed
ReviewCoordinationtocodex-auto-review, colocated with the existing durable review store atstate/review/repo-xxxxxxxx.review.lockacquisition with process identity, intent, git head, captured snapshot epoch, and owner-token guarded release.snapshot.epochbump/read support serialized throughsnapshot.epoch.lock.auto-review/store without makingAutoReviewStore::has_store_filesreport durable review data.Verification
cargo test -p codex-auto-reviewcargo fmt --manifest-path codex-rs/Cargo.toml --all --checkgit diff --checkjust bazel-lock-update(noMODULE.bazel.lockdiff)just bazel-lock-checkNote: background auto-review repeatedly failed before producing findings for this branch, with no actionable finding details. This PR was reviewed with independent read-only review agents instead.