Skip to content

Add auto-review coordination locks #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiny-code-bot merged 1 commit into from
Jun 18, 2026
Merged

Add auto-review coordination locks #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions codex-rs/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions codex-rs/auto-review/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ crc32fast = { workspace = true }
serde = { workspace = true, features = ["derive"] }
serde_json = { workspace = true }

[target.'cfg(unix)'.dependencies]
libc = { workspace = true }

[target.'cfg(windows)'.dependencies]
windows-sys = { version = "0.52", features = [
"Win32_Foundation",
"Win32_System_Threading",
] }

[dev-dependencies]
pretty_assertions = { workspace = true }
tempfile = { workspace = true }
11 changes: 10 additions & 1 deletion codex-rs/auto-review/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ use codex_utils_path::write_atomically;
use serde::Deserialize;
use serde::Serialize;

mod review_coord;

pub use review_coord::ReviewCoordination;
pub use review_coord::ReviewLockGuard;
pub use review_coord::ReviewLockInfo;

pub const SUMMARY_MAX_FINDINGS: usize = 20;
pub const SUMMARY_MAX_FIELD_BYTES: usize = 240;
pub const SUMMARY_MAX_BYTES: usize = 4096;
Expand Down Expand Up @@ -850,11 +856,14 @@ fn validate_safe_id(value: &str) -> Result<()> {
}

fn scoped_store_root(codex_home: &Path, scope: &Path) -> PathBuf {
scoped_review_root(codex_home, scope).join(STORE_DIR)
}

fn scoped_review_root(codex_home: &Path, scope: &Path) -> PathBuf {
codex_home
.join(STATE_DIR)
.join(REVIEW_DIR)
.join(repo_key(scope))
.join(STORE_DIR)
}

fn legacy_store_root(codex_home: &Path) -> PathBuf {
Expand Down
Loading
Loading