Skip to content

Wire auto-review runtime coordination#135

Merged
shiny-code-bot merged 1 commit into
mainfrom
auto-review-runtime-coordination
Jun 18, 2026
Merged

Wire auto-review runtime coordination#135
shiny-code-bot merged 1 commit into
mainfrom
auto-review-runtime-coordination

Conversation

@shiny-code-bot

Copy link
Copy Markdown
Collaborator

Summary

  • Hold a durable auto-review coordination lock for the lifetime of each detached background review task.
  • Reconcile orphaned in-flight background auto-review runs on session startup when no live coordination lock remains.
  • Add focused tests for lock lifetime and restart recovery.

Validation

  • cargo test -p codex-core --test all automatic_background_review_holds_coordination_lock_until_completion -- --nocapture
  • cargo test -p codex-core --test all session_startup_marks_orphaned_background_review_lost -- --nocapture
  • cargo check -p codex-core
  • cargo fmt --all --check
  • git diff --check

Review notes

  • Read-only agents reviewed the lifecycle and Every Code comparison. Follow-up findings were addressed: superseded-review lock retry, post-lock foreground cancellation recheck, and normalized recovery scope dedupe.
  • Background auto-review could not complete on this branch because the diff exceeded the configured 120k character limit; the terminal run failed before findings for size only.

@shiny-code-bot shiny-code-bot merged commit 1b82eab into main Jun 18, 2026
6 checks passed
@shiny-code-bot shiny-code-bot deleted the auto-review-runtime-coordination branch June 18, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant