fix: add .gitattributes to prevent binary corruption#8
Merged
Conversation
Add `.gitattributes` file to mark platform-specific native libraries as binary files, preventing git from applying text transformations that corrupt the binaries during CI commits.
Update `once_cell`, `serde`, and `serde_json` to match resolved versions.
calvinbrewer
approved these changes
Jun 27, 2025
coreyhn
added a commit
that referenced
this pull request
Jun 27, 2025
Add platform native library files to Rust change detection. This allows force rebuilds by deleting libraries when a clean rebuild of all platforms is needed. This approach integrates cleanly with the existing PR workflow without requiring manual workflow triggers or version bumps. The library commit in PR #8 failed to update all platforms, maybe due to a transient issue with the commit action. A validation step may be needed if this rebuild resolves the issue.
coreyhn
added a commit
that referenced
this pull request
Jun 28, 2025
Remove `.gitattributes` file (from PR #8) which is no longer needed since the GitHub API bypasses git's text transformation logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
.gitattributesfile to mark platform-specific native libraries as binary files, preventing git from applying text transformations that corrupt the binaries during CI commits.Update
once_cell,serde, andserde_jsonto match resolved versions (primarily doing this to have the native libraries be rebuilt).