Drawer#1790
Open
oscarcarlstrom wants to merge 2 commits into
Open
Conversation
Side-anchored overlay built on react-aria-components, mirroring the UNSAFE_Modal architecture (HeadingContext + Provider pattern for the auto-rendered close button). Reuses UNSAFE_Dialog and UNSAFE_DialogTrigger. - placement: right | left | top | bottom - slide-in/out animation via tw-animate-css with motion-reduce - isDismissable also disables Escape (isKeyboardDismissDisabled) - zIndex and className overrides as in UNSAFE_Modal Co-Authored-By: Claude <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: b3e0b62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Adds a comment + API sketch above the CustomBackground story noting a more elegant alternative to the `bg-X!` override — a typed `color` prop with a whitelist of supported backgrounds, expandable as needed, while still allowing `!`-prefix overrides for edge cases. To be discussed with the team. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oppsummering
Ny
UNSAFE_Drawer-komponent — en side-forankret overlay som glir inn fra valgt kant av skjermen. Bygger på samme arkitektur somUNSAFE_Modal(react-aria-components +HeadingContext+Provider-trikset for auto-rendret close-knapp), og gjenbrukerUNSAFE_DialogogUNSAFE_DialogTrigger. Ingen nye avhengigheter. Løser AB#120868.Endringer
placement-prop (right|left|top|bottom),isDismissable,zIndexogclassName. Slide-animasjon viatw-animate-cssmedmotion-reduce:animate-none, fade + backdrop-blur på overlay matcherUNSAFE_Modal.isDismissable={false}deaktiverer både klikk-utenfor ogEscape, og skjuler auto-close-knappen i headeren.Left/Top/Bottom,MultipleActions(Footer),Controlled,NotDismissable,CustomBackground(bg-overstyring med!-prefiks) ogCustomZIndex.Gjenstår
isDismissable={false}deaktiverer ikkeEscape. Bør tas i en oppfølgings-PR.