Deaktiver Escape-lukking når UNSAFE_Modal ikke er dismissable#1791
Open
oscarcarlstrom wants to merge 1 commit into
Open
Deaktiver Escape-lukking når UNSAFE_Modal ikke er dismissable#1791oscarcarlstrom wants to merge 1 commit into
oscarcarlstrom wants to merge 1 commit into
Conversation
Sets isKeyboardDismissDisabled={!isDismissable} on the underlying
RACModalOverlay so isDismissable={false} consistently disables both
outside-click and Escape. Same fix as the new UNSAFE_Drawer applies.
Co-Authored-By: Claude <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 3e6d9fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oppsummering
Oppfølger til #1790.
UNSAFE_Modallukket fortsatt medEscapeselv nårisDismissable={false}, fordi react-aria-components har en egenisKeyboardDismissDisabled-prop for tastatur-dismissal. Setter den nå basert påisDismissableslik at både klikk-utenfor ogEscapedeaktiveres samtidig — i tråd med hva prop-navnet tilsier.Endringer
isKeyboardDismissDisabled={!isDismissable}på_ModalOverlay.