Skip to content

REVERTED feat(drive-integration): adding remove button redesign [INTEG-4135]#11021

Merged
Franco Banfi (FBanfi) merged 3 commits into
drive-integration-v1.1from
integ-4135-remove-redesign
Jun 11, 2026
Merged

REVERTED feat(drive-integration): adding remove button redesign [INTEG-4135]#11021
Franco Banfi (FBanfi) merged 3 commits into
drive-integration-v1.1from
integ-4135-remove-redesign

Conversation

@FBanfi

@FBanfi Franco Banfi (FBanfi) commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Adds a Remove action to the mapping review selection menu in the drive-integration app, with a confirmation modal before content is unmapped from entry fields.

Approach

  • Selection menu redesign — EditMappingButton is now a split pill bar: "Edit content mapping" on the left, a divider, and a "Remove" action on the right (styles extracted to EditMappingButton.styles.ts via Emotion css).
  • Remove confirmation modal — New RemoveContentModal asks "Are you sure you'd like to remove this content from the entry?" with Cancel / Remove actions.
  • Remove flow in MappingView — Selecting mapped text shows Remove only when the selection overlaps mapped content. On confirm, the selected text/images are removed from every mapped field via existing applyTextExclusionToEntryBlockGraph / applyImageExclusionToEntryBlockGraph helpers.
  • Multi-field edge case — If the same text is mapped to multiple fields on one entry (e.g. body and summary), removal clears it from all affected fields in one action.

Testing steps

Automated tests for the Remove modal and the Mapping view added.

Grabacion.de.pantalla.2026-06-11.a.la.s.3.44.46.p.m.mov

Breaking Changes

No.

Dependencies and/or References

INTEG-4135

Deployment

No.

@FBanfi Franco Banfi (FBanfi) marked this pull request as ready for review June 11, 2026 17:29
@FBanfi Franco Banfi (FBanfi) requested review from a team as code owners June 11, 2026 17:29
@FBanfi Franco Banfi (FBanfi) merged commit 6a654fa into drive-integration-v1.1 Jun 11, 2026
12 checks passed
@FBanfi Franco Banfi (FBanfi) deleted the integ-4135-remove-redesign branch June 11, 2026 18:46
Franco Banfi (FBanfi) added a commit that referenced this pull request Jun 11, 2026
@FBanfi

Franco Banfi (FBanfi) commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator Author

I reverted this PR after merging it because I merged it by mistake in the feature branch without a review. There is a new exact same PR here: #11023

@FBanfi Franco Banfi (FBanfi) changed the title feat(drive-integration): adding remove button redesign [INTEG-4135] REVERTED feat(drive-integration): adding remove button redesign [INTEG-4135] Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant