feat(drive-integration): adding remove button redesign [INTEG-4135]#11023
Open
Franco Banfi (FBanfi) wants to merge 6 commits into
Open
feat(drive-integration): adding remove button redesign [INTEG-4135]#11023Franco Banfi (FBanfi) wants to merge 6 commits into
Franco Banfi (FBanfi) wants to merge 6 commits into
Conversation
…11021) * feat(drive-integration): adding remove button redesign [INTEG-4135] * refactor(drive-integration): image removal through three dots button * refactor(drive-integration): adding ability to remove images through selection [INTEG-4135]
Collaborator
Author
|
The original PR was this one: #11021. |
…ations [INTEG-4135] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JuliRossi
reviewed
Jun 11, 2026
| <Modal.Header title="Remove content from entry" onClose={onCancel} /> | ||
| <Modal.Content> | ||
| <Paragraph> | ||
| Are you sure you'd like to remove this content from the entry? |
Collaborator
There was a problem hiding this comment.
⛏️ I think it would be nice for it to say the entry you are removing it from, but it is a nitpick I would check with Erin
| const mappingKeys = new Set<string>(); | ||
| const selectedMappedSegments = root.querySelectorAll<HTMLElement>( | ||
| '[data-review-text-segment="true"][data-is-mapped="true"]' | ||
| '[data-review-text-segment="true"][data-is-mapped="true"], [data-review-image-segment="true"][data-is-mapped="true"]' |
Collaborator
There was a problem hiding this comment.
⚔️ We already have [data-is-mapped="true"] and [data-review-text-segment="true"] . Images have their own menu for removal. I would check this with Erin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a Remove action to the mapping review selection menu in the drive-integration app, with a confirmation modal before content is unmapped from entry fields.
Approach
"Edit content mapping"on the left, adivider, and a"Remove"action on the right (styles extracted toEditMappingButton.styles.tsvia Emotion css)."Are you sure you'd like to remove this content from the entry?"with Cancel / Remove actions.Testing steps
Automated tests for the Remove modal and the Mapping view added.
Grabacion.de.pantalla.2026-06-11.a.la.s.3.44.46.p.m.mov
Grabacion.de.pantalla.2026-06-11.a.la.s.4.09.47.p.m.mov
Breaking Changes
No.
Dependencies and/or References
INTEG-4135
Deployment
No.