Repository navigation
feat: filter and group the stats overview by language, genre or author #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
itsthisjustin
merged 2 commits into
crosspoint-reader:main
from
eszter007:feat/overview-filters
Oct 24, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎 Supported by static analysis
Script executed:
Repository: crosspoint-reader/crosspoint-sync
Length of output: 10078
Script executed:
Repository: crosspoint-reader/crosspoint-sync
Length of output: 16430
Script executed:
Repository: crosspoint-reader/crosspoint-sync
Length of output: 11956
Script executed:
Repository: crosspoint-reader/crosspoint-sync
Length of output: 25889
Script executed:
Repository: crosspoint-reader/crosspoint-sync
Length of output: 9802
Merge imported BookOrbit time into filtered book totals.
Filtered and grouped overviews build
books.timefrom device snapshots andreading_sessions, but they never callreadBookorbitStats. This omits imported BookOrbit seconds, sessions,today_seconds,week_seconds, and their reading days.Add imported BookOrbit data to the snapshot-side total before applying the existing
Math.maxagainstreading_sessions. Merge its daily allocations intoperDay;forBooksalready adds everyperDaydate to the reading-day set. This follows the existing unfiltered and per-book aggregation contract. Exported local sessions are already excluded byreadBookorbitStats, so do not add imported totals after the session maximum.Suggested fix
for (const [document, list] of snapshots) { const combined = combineBookStats(list); const t = entry(document); t.seconds = combined.seconds; t.sessions = combined.sessions; } + for (const document of info.keys()) { + const imported = readBookorbitStats(db, userId, statsDocuments(db, userId, document)); + if (!imported.book.sessions) continue; + const t = entry(document); + t.seconds += imported.book.seconds; + t.sessions += imported.book.sessions; + for (const d of imported.daily) { + const day = Math.floor(Date.parse(`${d.date}T00:00:00Z`) / 86400000) - EPOCH_DAY; + t.perDay.set(day, (t.perDay.get(day) ?? 0) + d.seconds); + } + } const sessionTotals = new Map<string, { seconds: number; count: number }>();