fix(e2e): mobile viewport toolbar and test coverage (Plan 201)#846
Merged
Conversation
Deploying do-epub-studio with
|
| Latest commit: |
4ec45c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://825deca4.do-epub-studio.pages.dev |
| Branch Preview URL: | https://fix-e2e-mobile-ci-failure-20.do-epub-studio.pages.dev |
🚀 Performance Report⚡ Startup & Interaction
🛠️ CI & Workflow
|
github-actions
Bot
added
documentation
Contributor
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 105 |
| Duplication | 9 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Owner
Author
|
Checking Codacy failure... |
Fix 20 failing mobile E2E tests by adding clickToolbarButton() helper that handles the container-query responsive toolbar overflow menu. Changes: - Add clickToolbarButton() and suppressWorkboxErrors() to fixtures.ts - Update 5 E2E test files for mobile viewport toolbar interaction - Add unit tests for NotificationBadge, NotificationPanel, LibraryPage, SettingsPage - Update LEARNINGS.md with mobile E2E and workbox SW patterns Closes #845
d-oit
force-pushed
the
fix/e2e-mobile-ci-failure-2026-07-24
branch
from
July 24, 2026 10:02
1230cba to
8e1b5bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clickToolbarButton()helper that handles the container-query responsive toolbar overflow menu on mobile viewportssuppressWorkboxErrors()helper to filter non-fatal workbox SW registration PAGE ERRORsChanges
E2E Fix (Closes #845)
apps/tests/fixtures.ts— AddedclickToolbarButton()andsuppressWorkboxErrors()helpersedge-cases.spec.ts— Settings buttonaccessibility-audit.spec.ts— Settings button (2 tests)in-book-search.spec.ts— Search button (3 tests)login-and-book-load.spec.ts— Settings buttonreader-annotations-and-admin.spec.ts— Comment, Bookmarks, Export Notes buttonsTest Coverage (P2)
notification-badge.test.tsx— 7 tests (render, fetch, click, error handling)notification-panel.test.tsx— 7 tests (render, loading, empty, notifications, actions)library-page.test.tsx— 6 tests (loading, error, empty, grouped books, links)settings-page.test.tsx— 8 tests (render, themes, fonts, locale, storage, aria-pressed)Root Cause
The reader toolbar uses container queries (
cq-reader-toolbar-actions/cq-reader-toolbar-overflow) to switch between desktop (direct icon buttons) and mobile (overflow "More Options" menu) layouts. E2E tests on mobile viewports (iphone/pixel) were trying to click desktop-style buttons that are hidden on mobile.Verification
pnpm lint— PASSpnpm typecheck— PASS (7/7)Plan
See
.mimocode/plans/1784877486740-shiny-moon.mdfor full GOAP plan.