chore: add display names and descriptions to IAM roles#132
Open
kevwilliams wants to merge 1 commit intomainfrom
Open
chore: add display names and descriptions to IAM roles#132kevwilliams wants to merge 1 commit intomainfrom
kevwilliams wants to merge 1 commit intomainfrom
Conversation
kevwilliams
commented
Mar 12, 2026
| name: activity.miloapis.com-viewer | ||
| namespace: milo-system | ||
| annotations: | ||
| kubernetes.io/display-name: Viewer |
Contributor
Author
There was a problem hiding this comment.
@scotwells maybe this should be Activity Viewer? but does that conflict with Activity Viewer? how can we make this more clear?
Contributor
There was a problem hiding this comment.
Activity Viewer would make sense.
Contributor
Author
There was a problem hiding this comment.
maybe we call this one Activity Owner?
Contributor
There was a problem hiding this comment.
Ah, I see. This role is the aggregated Activity Viewer (activities, events, and audit logs) and the other one is just activity viewing (activity feed). Maybe we name the other one "Activity Feed Viewer"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kubernetes.io/display-nameandkubernetes.io/descriptionannotations to all 5activity.miloapis.comIAM rolesactivity-viewer,audit-log-querier,event-viewer,policy-manager, and the compositeviewerroleTest plan
kubectl get roles -n milo-system -o yaml | grep -A2 annotations