Skip to content

chore: add display names and descriptions to IAM roles #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevwilliams wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: add display names and descriptions to IAM roles #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/milo/iam/roles/activity-viewer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ kind: Role
metadata:
name: activity.miloapis.com-activity-viewer
namespace: milo-system
annotations:
kubernetes.io/display-name: Activity Viewer
kubernetes.io/description: View activity feeds and query historical activities and facets
labels:
app.kubernetes.io/name: activity-viewer
app.kubernetes.io/part-of: activity.miloapis.com
Expand Down
3 changes: 3 additions & 0 deletions config/milo/iam/roles/audit-log-querier.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ kind: Role
metadata:
name: activity.miloapis.com-audit-log-querier
namespace: milo-system
annotations:
kubernetes.io/display-name: Audit Log Querier
kubernetes.io/description: Query audit logs and audit log facets
labels:
app.kubernetes.io/name: audit-log-querier
app.kubernetes.io/part-of: activity.miloapis.com
Expand Down
3 changes: 3 additions & 0 deletions config/milo/iam/roles/event-viewer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ kind: Role
metadata:
name: activity.miloapis.com-event-viewer
namespace: milo-system
annotations:
kubernetes.io/display-name: Event Viewer
kubernetes.io/description: View event feeds and query cluster events and facets
labels:
app.kubernetes.io/name: event-viewer
app.kubernetes.io/part-of: activity.miloapis.com
Expand Down
3 changes: 3 additions & 0 deletions config/milo/iam/roles/policy-manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ kind: Role
metadata:
name: activity.miloapis.com-policy-manager
namespace: milo-system
annotations:
kubernetes.io/display-name: Activity Policy Manager
kubernetes.io/description: Full access to activity policies and policy previews
labels:
app.kubernetes.io/name: policy-manager
app.kubernetes.io/part-of: activity.miloapis.com
Expand Down
3 changes: 3 additions & 0 deletions config/milo/iam/roles/viewer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ kind: Role
metadata:
name: activity.miloapis.com-viewer
namespace: milo-system
annotations:
kubernetes.io/display-name: Viewer
Copy link
Copy Markdown
Contributor Author

@kevwilliams kevwilliams Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scotwells maybe this should be Activity Viewer? but does that conflict with Activity Viewer? how can we make this more clear?

Copy link
Copy Markdown
Contributor Author

@kevwilliams kevwilliams Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

Copy link
Copy Markdown
Contributor

@scotwells scotwells Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Activity Viewer would make sense.

Copy link
Copy Markdown
Contributor Author

@kevwilliams kevwilliams Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but then what would we call this one?

Copy link
Copy Markdown
Contributor Author

@kevwilliams kevwilliams Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we call this one Activity Owner?

Copy link
Copy Markdown
Contributor

@scotwells scotwells Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. This role is the aggregated Activity Viewer (activities, events, and audit logs) and the other one is just activity viewing (activity feed). Maybe we name the other one "Activity Feed Viewer"?

kubernetes.io/description: View all activity data including activities, events, and audit logs
labels:
app.kubernetes.io/name: viewer
app.kubernetes.io/part-of: activity.miloapis.com
Expand Down
Loading