Fix stale status blocking deployment reconciliation#551
Merged
Conversation
…oncilers Move ObservedGeneration assignment before the DeepEqual check in GrantCreationPolicyReconciler and ClaimCreationPolicyReconciler so that generation-only changes (where conditions remain identical) still trigger a status write. Without this fix, Flux health checks permanently report "InProgress" because observedGeneration never advances. The other quota reconcilers (ResourceRegistration, ResourceGrant, AllowanceBucket) already follow the correct pattern. Fixes #550 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Verify that observedGeneration advances even when a spec change produces identical conditions — the exact scenario that caused stale status blocking Flux reconciliation in #550. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zachsmith1
approved these changes
Apr 2, 2026
ecv
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ObservedGenerationassignment before theDeepEqualstatus diff check inGrantCreationPolicyReconcilerandClaimCreationPolicyReconcilerso that spec changes which produce the same validation result still trigger a status update.observedGenerationnever advances when conditions remain unchanged, causing Flux health checks to permanently report "InProgress".ResourceRegistration,ResourceGrant,AllowanceBucket) already follow the correct pattern and required no changes.Fixes #550
Test plan
task test:unit)observedGenerationadvances after a no-op spec change on aGrantCreationPolicyorClaimCreationPolicy🤖 Generated with Claude Code