You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(ghcredentials): run real gh tests outside the -short unit tier - #1666
The real-gh tests spawn gh with a fixed 1.5s per-account lookup budget. In the -short unit tier (all packages in parallel, -race) gh start-up occasionally exceeds it, so HostAccounts returns token_lookup_failed (failure time 1.51s in runs 39884640461 and 39833879193). The GitHub Credential Host Tests job runs the same tests uncontended and passed in every one of those runs. Skip them under -short; the dedicated job (no -short, DEVSY_TEST_REAL_GH=1) still requires them.
Summary by CodeRabbit
Tests
Short-mode test runs now skip tests that require the native GitHub CLI, so those CLI-dependent tests do not run in that mode.
In other test runs, the existing check for CLI installation remains unchanged. This update affects test execution only and does not change application behavior or end-user functionality.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: b47dcd63-b520-4c82-8aa1-897ec4158c12
📥 Commits
Reviewing files that changed from the base of the PR and between 2ed6d87 and 1851b16.
📒 Files selected for processing: 1
pkg/ghcredentials/host_real_test.go
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.
📝 Walkthrough
requireRealGH now skips native GitHub CLI tests when Go short-test mode is enabled. Outside short-test mode, the existing CLI availability check remains.
The description clearly explains the problem, the cause, the observed failures, and the intended test behavior. It omits the required template sections for change type, AI assistance, testing, checkli…
Add the required template sections. Identify the change type, state whether AI assistance was used, document tests and manual verification, complete the checklist, and specify an issue reference or write "Fixes none" or "Refs none".
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 3 passed
Check name
Status
Explanation
Title check
The title is concise, uses Conventional Commits form, and accurately describes moving real gh tests outside the -short unit tier.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Description check
Explanation
The description clearly explains the problem, the cause, the observed failures, and the intended test behavior. It omits the required template sections for change type, AI assistance, testing, checklist items, and issue linkage.
Resolution
Add the required template sections. Identify the change type, state whether AI assistance was used, document tests and manual verification, complete the checklist, and specify an issue reference or write "Fixes none" or "Refs none".
✨ Finishing Touches
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The real-gh tests spawn gh with a fixed 1.5s per-account lookup budget. In the -short unit tier (all packages in parallel, -race) gh start-up occasionally exceeds it, so HostAccounts returns token_lookup_failed (failure time 1.51s in runs 39884640461 and 39833879193). The GitHub Credential Host Tests job runs the same tests uncontended and passed in every one of those runs. Skip them under -short; the dedicated job (no -short, DEVSY_TEST_REAL_GH=1) still requires them.
Summary by CodeRabbit