Fix cache key for native modules build#2733
Merged
Merged
Conversation
Contributor
Greptile SummaryThis PR reuses the native-module cache key across the marker and build jobs. The main changes are:
Confidence Score: 4/5The cache save path can behave incorrectly when the marker job fails before producing outputs.
.github/workflows/ci.yml Important Files Changed
Reviews (1): Last reviewed commit: "Fix cache key for native modules build" | Re-trigger Greptile |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
leshy
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a mistake here, so the key that was being saved in the cache was being computed on the built files and not matching the original key we are checking against.
This should ensure that cmu-nav-natives is correctly built in future and unrelated PRs stop deploying to Cachix.