Skip to content

Fix cache key for native modules build #2733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dreamsorcerer merged 1 commit into from
Jul 6, 2026
+8 −2
Merged

Fix cache key for native modules build #2733

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ jobs:
contents: read # For checkout
outputs:
cache-hit: ${{ steps.marker.outputs.cache-hit }}
key: ${{ steps.cache-key.outputs.key }}
steps:
- name: Checkout files used for cache key
uses: actions/checkout@v6
Expand All @@ -333,12 +334,17 @@ jobs:
bin/build-cmu-nav-natives
dimos/navigation/cmu_nav/modules
sparse-checkout-cone-mode: false
- name: Compute cache key
# Recomputing the key in cmu-nav-natives after build breaks the key.
# Save here so it can be reused verbatim.
id: cache-key
run: echo "key=cmu-nav-natives-${{ hashFiles('bin/build-cmu-nav-natives', 'dimos/navigation/cmu_nav/modules/**') }}" >> "$GITHUB_OUTPUT"
- name: Look up marker cache
id: marker
uses: actions/cache/restore@v4
with:
path: /tmp/cmu-nav-natives-marker
key: cmu-nav-natives-${{ hashFiles('bin/build-cmu-nav-natives', 'dimos/navigation/cmu_nav/modules/**') }}
key: ${{ steps.cache-key.outputs.key }}
lookup-only: true

cmu-nav-natives:
Expand Down Expand Up @@ -409,7 +415,7 @@ jobs:
uses: actions/cache/save@v4
with:
path: /tmp/cmu-nav-natives-marker
key: cmu-nav-natives-${{ hashFiles('bin/build-cmu-nav-natives', 'dimos/navigation/cmu_nav/modules/**') }}
key: ${{ needs.cmu-nav-natives-marker.outputs.key }}
Comment thread
Dreamsorcerer marked this conversation as resolved.

self-hosted-tests:
# Skip on PRs from forks which would expose the self-hosted runner to untrusted code from external contributors.
Expand Down
Loading