Skip to content

Fix HTTP Host header example#336

Merged
AndreyVMarkelov merged 2 commits into
mainfrom
codex/fix-http-host-header
Jul 17, 2026
Merged

Fix HTTP Host header example#336
AndreyVMarkelov merged 2 commits into
mainfrom
codex/fix-http-host-header

Conversation

@AndreyVMarkelov

Copy link
Copy Markdown
Contributor

Summary

  • remove the URL scheme from the generated HTTP Host header
  • add regression coverage for the rendered HTTP request

Why

HTTP Host header values contain only the authority hostname, not a URL scheme. The explorer currently generates Host: https://api.dropboxapi.com, which is invalid.

This supersedes #4 and preserves the fix originally proposed by @cakoose.

Validation

  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build
  • git diff --check

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.26%. Comparing base (d43d850) to head (0456a44).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
+ Coverage   10.68%   14.26%   +3.58%     
==========================================
  Files           6        6              
  Lines        5775     5775              
  Branches        4       28      +24     
==========================================
+ Hits          617      824     +207     
+ Misses       5158     4950     -208     
- Partials        0        1       +1     
Flag Coverage Δ
unit 14.26% <100.00%> (+3.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AndreyVMarkelov
AndreyVMarkelov marked this pull request as ready for review July 17, 2026 22:58
@AndreyVMarkelov
AndreyVMarkelov merged commit 7beb365 into main Jul 17, 2026
6 checks passed
@AndreyVMarkelov
AndreyVMarkelov deleted the codex/fix-http-host-header branch July 17, 2026 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant