Skip to content

codeview: HTTP "Host" header should not include "https://"#4

Closed
cakoose wants to merge 1 commit into
dropbox:mainfrom
cakoose:host-header
Closed

codeview: HTTP "Host" header should not include "https://"#4
cakoose wants to merge 1 commit into
dropbox:mainfrom
cakoose:host-header

Conversation

@cakoose

@cakoose cakoose commented Jun 2, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@greg-db
greg-db requested a review from qimingyuan June 4, 2018 13:46
@greg-db

greg-db commented Jun 4, 2018

Copy link
Copy Markdown

Thanks!

@rogebrd

rogebrd commented Nov 3, 2020

Copy link
Copy Markdown
Contributor

Hello, we have since migrated to the main branch being the primary branch. If you would still like to merge this PR, could you please rebase and open it against main?

@CLAassistant

CLAassistant commented Apr 16, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cakoose
cakoose changed the base branch from master to main April 17, 2022 00:08
@AndreyVMarkelov

Copy link
Copy Markdown
Contributor

Thanks @cakoose — this fix is still needed. I recreated it on current main with regression coverage in #336, so I’m closing this original PR as superseded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants