Repository navigation
fix(branch): stop retry storms on ACL/SQL failures and no-op metadata edits - #27
Merged
Merged
Conversation
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
2026-10-23 DEV: repeated library name/description PUTs created orphan metadata commits and repeatedly attempted
Branch/master FOR UPDATE. An ACL-protected library has no file-tree delta for metadata-only commits; native final ACL verification rejects it, butedit_repo()andrevert_on_server()retried every negative publication result without bounds. The C file-commit path could also retry SQL failures as if they were HEAD conflicts.Minimal fix
SEAF_BRANCH_UPDATE_HEAD_CONFLICT(-3) only for the confirmed old-HEAD mismatch; preserve the fail-closed ACL rejection (-2) and SQL/transaction failure (-1).edit_repo(), skip identical name/description without creating a commit; retain caller-supplied metadata/actor across a HEAD-conflict retry; retry only confirmed HEAD conflicts, up to 3 times with bounded randomized delay.revert_on_server()(including its abort lifecycle event).gen_new_commit_guarded(), stop on unexpected/SQL failures; correct strict no-op error mapping.Scope
No database tables, ACL policy semantics, authentication, or EAP synchronization changes. The EAP stop-rename/stop-automatic-replay patch
jcetech/etech-eap@bb347ddeis already in itsdevbranch. This PR deliberately does not authorize metadata changes on an ACL-protected repo; those operations still fail closed, but terminate promptly until explicit admin metadata authorization is designed.Validation / merge gates
python3 -m unittest tests.test_cf_branch_retry_contract.