Repository navigation
Fix SFINAE calling a function template with deduced return type and pending definition - #322
Open
cpplearner wants to merge 3 commits into
Open
cpplearner wants to merge 3 commits into
cpplearner wants to merge 3 commits into
Conversation
Contributor
Author
|
daveedvdv-nvidia
requested changes
Oct 31, 2026
daveedvdv-nvidia
left a comment
daveedvdv-nvidia
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking this on!
I've created issue #453 from the discussion.
The fix looks fine to me (I made a note of one stylistic nit). To be complete we need a few more things:
| tsym = prototype_template_if_template_symbol(tip->template_sym); | ||
| if (tsym->defined) { | ||
| could_be_instantiated = TRUE; | ||
| } else if (has_pending_template_definition_from_module( |
Contributor
There was a problem hiding this comment.
I'd slightly prefer a single if (tsym->defined || has_pending... ) ... statement here.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With modules, it is possible that a function template definition exists in a module but the definition is not yet loaded. In such a case,
routine->definedis false, despite the existence of a definition. Previously, substitution failed if such a function template is called in a SFINAE context and the function template has a deduced return type. This is fixed in this PR.See #242 for an example.
Fixes #242