Skip to content

Fix SFINAE calling a function template with deduced return type and pending definition #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cpplearner wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix SFINAE calling a function template with deduced return type and pending definition #322

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddfadcf
Fix SFINAE for function template with deduced return type and pending…
cpplearner Oct 17, 2026
8c35348
Limit the check to template instances
cpplearner Oct 18, 2026
d2c8e30
Drive by: simplify the `friend_defined_in_instantiation` check
cpplearner Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/exprutil.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ exprutil.c -- Expression scanning utility routines.
#include "lower_il.h"
#endif /* DO_IL_LOWERING */
#include "statements.h"
#include "modules.h"
#if USE_X86_FUNCTION_MULTIVERSIONING
#include "sys_predef.h"
#endif /* USE_X86_FUNCTION_MULTIVERSIONING */
Expand Down Expand Up @@ -18100,9 +18101,11 @@ reference entry, or is NULL if none is needed.
tsym = prototype_template_if_template_symbol(tip->template_sym);
if (tsym->defined) {
could_be_instantiated = TRUE;
} else if (has_pending_template_definition_from_module(

@daveedvdv-nvidia daveedvdv-nvidia Oct 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd slightly prefer a single if (tsym->defined || has_pending... ) ... statement here.

routine->assoc_template)) {
could_be_instantiated = TRUE;
} /* if */
} else if (routine_sym->variant.routine.ptr
->friend_defined_in_instantiation) {
} else if (routine->friend_defined_in_instantiation) {
could_be_instantiated = TRUE;
} /* if */
if (!could_be_instantiated) {
Expand Down
Loading