Skip to content

coordinator: remove ownerreference from configmaps#2515

Merged
burgerdev merged 2 commits into
mainfrom
burgerdev/free-configmaps
Jul 9, 2026
Merged

coordinator: remove ownerreference from configmaps#2515
burgerdev merged 2 commits into
mainfrom
burgerdev/free-configmaps

Conversation

@burgerdev

@burgerdev burgerdev commented Jul 8, 2026

Copy link
Copy Markdown
Member

The ConfigMaps used to store Coordiantor history are not owned by the Coordinator StatefulSet anymore. Cleaning them up now requires manual deletion, but the ConfigMaps can now be used by more than one Coordinator set and restored ConfigMaps are consistent with the ones created by the Coordinator.

Fixes CON-208.
Fixes CON-220.
Fixes CON-205.

@burgerdev burgerdev added the changelog PRs that should be part of the release notes label Jul 8, 2026
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Do the documentation changes need to be backported?

Changes to /docs/docs won't be visible until the next release.
If you are fixing something in the docs that should be immediately visible, the changes needs to be made to both /docs/docs and /docs/versioned_docs/version-X.Y, where X.Y is the version of the latest minor release.
This can be done in this same PR.

  • Yes, this should be backported to the current version of the docs.
  • No, the PR only contains docs changes relevant for future versions.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-09 06:42 UTC

@burgerdev burgerdev force-pushed the burgerdev/free-configmaps branch from dc4f53a to 4d3eac8 Compare July 8, 2026 07:42
@linear-code

linear-code Bot commented Jul 8, 2026

Copy link
Copy Markdown

CON-208

CON-220

CON-205

@burgerdev burgerdev requested a review from charludo July 8, 2026 08:04
Comment thread internal/history/configmapstore/configmapstore_test.go Outdated
Comment thread internal/history/configmapstore/configmapstore_test.go
@burgerdev burgerdev force-pushed the burgerdev/labeling-with-strategy branch 2 times, most recently from b41e4ee to 5ac6f3e Compare July 8, 2026 13:54
@burgerdev burgerdev force-pushed the burgerdev/labeling-with-strategy branch from 5ac6f3e to 7cbb310 Compare July 8, 2026 14:06
Base automatically changed from burgerdev/labeling-with-strategy to main July 8, 2026 16:56
@burgerdev burgerdev force-pushed the burgerdev/free-configmaps branch 3 times, most recently from fad7f5a to 42db392 Compare July 8, 2026 17:08
@burgerdev burgerdev requested a review from charludo July 8, 2026 17:08
@burgerdev burgerdev force-pushed the burgerdev/free-configmaps branch from 42db392 to dc37f5b Compare July 8, 2026 19:35
@burgerdev

burgerdev commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

I discovered a regression while working on the multi-coordinator e2e test: the configmaps returned to the client were missing the TypeMeta. Fixed that and added a regression test.

@charludo charludo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll open a PR for govulncheck...

@burgerdev burgerdev merged commit 4ba8aa4 into main Jul 9, 2026
20 of 21 checks passed
@burgerdev burgerdev deleted the burgerdev/free-configmaps branch July 9, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog PRs that should be part of the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants