coordinator: remove ownerreference from configmaps#2515
Merged
Conversation
Do the documentation changes need to be backported?Changes to
|
|
dc4f53a to
4d3eac8
Compare
charludo
reviewed
Jul 8, 2026
b41e4ee to
5ac6f3e
Compare
5ac6f3e to
7cbb310
Compare
fad7f5a to
42db392
Compare
42db392 to
dc37f5b
Compare
Member
Author
|
I discovered a regression while working on the multi-coordinator e2e test: the configmaps returned to the client were missing the |
charludo
approved these changes
Jul 9, 2026
charludo
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks! I'll open a PR for govulncheck...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ConfigMaps used to store Coordiantor history are not owned by the CoordinatorStatefulSetanymore. Cleaning them up now requires manual deletion, but the ConfigMaps can now be used by more than one Coordinator set and restoredConfigMaps are consistent with the ones created by the Coordinator.Fixes CON-208.
Fixes CON-220.
Fixes CON-205.