Make ItemManager not a singleton#589
Merged
Merged
Conversation
danirabbit
approved these changes
Jun 19, 2026
There is no benefit of it being a singleton and singletons often bring a bunch of problems and lead to suboptimal architecture.
leolost2605
force-pushed
the
leolost/item-manager-no-singleton
branch
from
7a2c936 to
33ecabb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no benefit of it being a singleton
and singletons often bring a bunch of problems
and lead to suboptimal architecture.