LocaleManager: set system locale and keyboard via dbus#205
Merged
Conversation
ryonakano
reviewed
Jun 15, 2024
Member
|
Also, maybe we can update the
|
Member
Author
|
@ryonakano thanks for the thorough review! Addressed those feedback points :) |
ryonakano
reviewed
Jun 16, 2024
ryonakano
reviewed
Jun 18, 2024
ryonakano
left a comment
Member
There was a problem hiding this comment.
Just one small nitpicking, otherwise looks good and works as expected.
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
Member
Author
|
@ryonakano thanks for catching that! |
ryonakano
approved these changes
Jun 18, 2024
ryonakano
left a comment
Member
There was a problem hiding this comment.
Code looks good and works as expected. Thank you for your work!
Member
Author
|
Thanks for your thorough review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As recommended in #147 (comment)