Skip to content

chore: pin fflate@0.8.2#751

Merged
Pixel998 merged 1 commit into
mainfrom
pin-fflate
May 17, 2026
Merged

chore: pin fflate@0.8.2#751
Pixel998 merged 1 commit into
mainfrom
pin-fflate

Conversation

@fasttime
Copy link
Copy Markdown
Member

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

Similar to eslint/eslint#20877 and eslint/rewrite#458.

This PR fixes a failure when running lint:types scripts. An example in CI:

https://github.com/eslint/js/actions/runs/25960118925/job/76343013673

Run npm run lint:types

> lint:types
> npm run lint:types --workspaces --if-present


> eslint-scope@9.1.2 lint:types
> attw --pack

error while checking file:
Cannot read properties of undefined (reading 'filename')
npm error Lifecycle script `lint:types` failed with error:
npm error code 3
npm error path /home/runner/work/js/js/packages/eslint-scope
npm error workspace eslint-scope@9.1.2
npm error location /home/runner/work/js/js/packages/eslint-scope
npm error command failed
npm error command sh -c attw --pack

...

What changes did you make? (Give an overview)

As explained in arethetypeswrong/arethetypeswrong.github.io#258, the problem is caused by @arethetypeswrong/core relying on an internal behavior of fflate, which has changed in recently released v0.8.3.

This PR adds an overrides to package.json to pin fflate to v0.8.2 for @arethetypeswrong/core.

Related Issues

refs eslint/eslint#20877
refs eslint/rewrite#458

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage May 16, 2026
@fasttime fasttime marked this pull request as ready for review May 16, 2026 20:33
@fasttime fasttime mentioned this pull request May 16, 2026
3 tasks
Copy link
Copy Markdown
Contributor

@Pixel998 Pixel998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Pixel998 Pixel998 merged commit 960ad59 into main May 17, 2026
19 checks passed
@Pixel998 Pixel998 deleted the pin-fflate branch May 17, 2026 01:53
@github-project-automation github-project-automation Bot moved this from Needs Triage to Complete in Triage May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants