[GUI] Create outcome editor panel for extensive forms#947
Merged
Conversation
Member
Author
|
All, this is also still WIP but testing and suggestions are very welcomed. |
Member
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This changes the UX for creating and editing outcomes in the extensive form.
Previously, we attempted to edit payoffs in the extensive form by popping up a text control more or less in the "right" place on the extensive form canvas, and allowing edits via e.g. tab traversal. This had a number of poor features:
This replaces the editing mechanism with a popup window which displays the outcome label and all payoffs. Edits are accepted by
Enteror clicking elsewhere in the parent window, and are dismissed viaEsc, so changes to the outcome are atomic at the edit level (rather than the individual payoffs level as before).