Skip to content

[GUI] Create outcome editor panel for extensive forms#947

Merged
tturocy merged 8 commits into
masterfrom
gui_outcome_edit
Jun 18, 2026
Merged

[GUI] Create outcome editor panel for extensive forms#947
tturocy merged 8 commits into
masterfrom
gui_outcome_edit

Conversation

@tturocy

@tturocy tturocy commented Jun 17, 2026

Copy link
Copy Markdown
Member

This changes the UX for creating and editing outcomes in the extensive form.

Previously, we attempted to edit payoffs in the extensive form by popping up a text control more or less in the "right" place on the extensive form canvas, and allowing edits via e.g. tab traversal. This had a number of poor features:

  • It was quite brittle and doesn't work very well with having to check for and validate "unsaved changes" in an edit.
  • It did not expose outcome labels - which we now consider to be important (in fact essential)
  • Even when editing only one payoff, it still makes sense to be thinking about the outcome as being associated with a vector of payoffs.

This replaces the editing mechanism with a popup window which displays the outcome label and all payoffs. Edits are accepted by Enter or clicking elsewhere in the parent window, and are dismissed via Esc, so changes to the outcome are atomic at the edit level (rather than the individual payoffs level as before).

@tturocy

tturocy commented Jun 17, 2026

Copy link
Copy Markdown
Member Author

All, this is also still WIP but testing and suggestions are very welcomed.

@tturocy tturocy added this to the gambit-16.7.0 milestone Jun 17, 2026
@edwardchalstrey1

Copy link
Copy Markdown
Member

Working for me, though I wonder if there's anything you can do to make it clearer that double click lets you edit the outcomes. Also, it then made me think "why can't I double click to edit action labels"

Screenshot 2026-06-18 at 11 50 42

@d-kad

d-kad commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

looks good to me -- one small thing to flag, likely outside this PR's scope: payoff input doesn't normalize negative zero
Screenshot 2026-06-18 at 12 24 47

@tturocy tturocy marked this pull request as ready for review June 18, 2026 18:37
@tturocy tturocy merged commit 4b5e96c into master Jun 18, 2026
26 checks passed
@tturocy tturocy deleted the gui_outcome_edit branch June 18, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants