feat(server-utils): Implement orchestrion-based instrumentation for vercel-ai v6#21658
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mydea
force-pushed
the
fn/vercel-ai-v7
branch
9 times, most recently
from
9145703 to
abad3a9
Compare
mydea
force-pushed
the
fn/try-orchestrion
branch
from
3417464 to
d05d40e
Compare
Contributor
size-limit report 📦
|
mydea
force-pushed
the
fn/try-orchestrion
branch
from
d05d40e to
98fac43
Compare
mydea
changed the title
mydea
requested review from
JPeer264 and
andreiborza
and removed request for
a team
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
JPeer264
approved these changes
Jun 29, 2026
JPeer264
left a comment
JPeer264
left a comment
Member
There was a problem hiding this comment.
Haven't found any major issues. Tests are failing though and clanker has some objections
| return isRecord(model) ? asString(model[field]) : undefined; | ||
| } | ||
|
|
||
| function asString(value: unknown): string | undefined { |
Member
There was a problem hiding this comment.
super-l: Maybe it makes sense to outsource these functions in a helper? vercel-ai-dc-subscriber.ts is also using some of the helpers
mydea
force-pushed
the
fn/try-orchestrion
branch
from
05fd48d to
89bf321
Compare
mydea
force-pushed
the
fn/try-orchestrion
branch
from
89bf321 to
c3f5431
Compare
andreiborza
approved these changes
Jul 1, 2026
| // A single model instance shared by two concurrent `streamText` calls carries only one | ||
| // captured-parent slot, so both model calls must still land under their own `invoke_agent` — not | ||
| // collapse onto whichever operation resolved the shared model last. | ||
| test.skipIf(version === '7' && nodeVersion === 18)( |
Member
There was a problem hiding this comment.
q: Why are we skipping this test on v7?
Member
Author
There was a problem hiding this comment.
added a better comment here!
Comment on lines
+30
to
+34
| * Like the v7 subscriber, each operation channel is wired up via | ||
| * {@link bindTracingChannelToSpan}, which binds the opened span into the runtime's | ||
| * async context for the duration of the traced call and ends it when the call | ||
| * settles. That binding is what lets the model call below find its enclosing | ||
| * `invoke_agent` span via the active context (see {@link resolveModelCallParent}). |
Member
There was a problem hiding this comment.
nit: I'd drop this, it doesn't really add much for understanding, it explains bindTracingChannelToSpan which should already be explained elsewhere.
Member
Author
There was a problem hiding this comment.
this has all been refactored a bit and is hopefully easier/cleaner to understand now.
mydea
force-pushed
the
fn/try-orchestrion
branch
2 times, most recently
from
f3e62c4 to
1731a89
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1731a89. Configure here.
mydea
added a commit
that referenced
this pull request
Jul 6, 2026
This PR just splits up the orchestrion config for instrumentation into a file per instrumentation, making it a bit cleaner and easier to follow. This is on top of #21658
49 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using orchestrion, this replaces the regular
vercelAiIntegrationwith the channel-variant. This today supports vercel ai v6 and v7 (v5/v4 support TBD).Test coverage exists and everything passes. This does not add any event processors etc. anymore, everything works inside of the integrations.
OTEL Spans emitted directly by vercel-ai v6 or below are ignored to avoid double instrumentation.