chore: Auto-request mobile team review on public API changes#6383
Merged
Conversation
Add a CODEOWNERS rule for the committed api-extractor report (packages/core/etc/sentry-react-native.api.md). Any PR that changes the public API regenerates this file, so @getsentry/team-mobile is now auto-requested as a reviewer on API changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
Per review feedback, list the existing global owners on the API report line as well, so they remain code owners of the file (last-matching pattern wins) and the mobile team is added rather than replacing them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
antonis
commented
Jun 30, 2026
| * @alwx @antonis @lucas-zimerman | ||
|
|
||
| # Public API surface — also request a mobile SDK team review on API changes | ||
| /packages/core/etc/sentry-react-native.api.md @alwx @antonis @lucas-zimerman @getsentry/team-mobile |
Contributor
Author
There was a problem hiding this comment.
Updated to also add the existing owners following up on https://github.com/getsentry/sentry-java/pull/5661/changes#r3499468969 and consulting the GH doc https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
Collaborator
There was a problem hiding this comment.
Just wondering, why? Doesn't the first line also covers the API changes?
Contributor
Author
There was a problem hiding this comment.
I followed up on this feedback getsentry/sentry-java#5661 (comment)
It seems that the second line would override the first one for the specific file resulting in just adding the team:
# Order is important; the last matching pattern takes the most
# precedence. When someone opens a pull request that only
# modifies JS files, only @js-owner and not the global
# owner(s) will be requested for a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Adds a CODEOWNERS rule for the committed api-extractor report,
packages/core/etc/sentry-react-native.api.md💡 Motivation and Context
Public API changes in the mobile SDKs should be reviewed by another mobile SDK team
member for cross-SDK consistency.
💚 How did you test it?
Manually
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps