Skip to content

chore: Auto-request mobile team review on public API changes #6383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 2 commits into from
Jul 1, 2026
+3 −0
Merged

chore: Auto-request mobile team review on public API changes #6383

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0e20ce
chore: Auto-request mobile team review on public API changes
antonis Jun 30, 2026
4ad34eb
chore: Keep existing code owners alongside mobile team on API file
antonis Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
* @alwx @antonis @lucas-zimerman

# Public API surface — also request a mobile SDK team review on API changes
/packages/core/etc/sentry-react-native.api.md @alwx @antonis @lucas-zimerman @getsentry/team-mobile

@antonis antonis Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to also add the existing owners following up on https://github.com/getsentry/sentry-java/pull/5661/changes#r3499468969 and consulting the GH doc https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

@lucas-zimerman lucas-zimerman Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, why? Doesn't the first line also covers the API changes?

@antonis antonis Jul 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed up on this feedback getsentry/sentry-java#5661 (comment)
It seems that the second line would override the first one for the specific file resulting in just adding the team:

# Order is important; the last matching pattern takes the most
# precedence. When someone opens a pull request that only
# modifies JS files, only @js-owner and not the global
# owner(s) will be requested for a review.

Loading