[PoC] feat(ourlogs): add truncate RPC parameter for logs events query#115638
Closed
JoshuaKGoldberg wants to merge 1 commit into
Closed
[PoC] feat(ourlogs): add truncate RPC parameter for logs events query#115638JoshuaKGoldberg wants to merge 1 commit into
JoshuaKGoldberg wants to merge 1 commit into
Conversation
github-actions
Bot
added
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.52% |
JoshuaKGoldberg
force-pushed
the
logs-query-truncate
branch
from
f73305d to
5748f73
Compare
JoshuaKGoldberg
commented
May 15, 2026
| result_value = anyvalue_to_python(result) | ||
| result_value = process_value(result_value) | ||
| if max_string_length is not None and isinstance(result_value, str): | ||
| result_value = result_value[:max_string_length] |
Member
Author
There was a problem hiding this comment.
[Todo] We'd probably want to add a ... or something. Left out to keep this prototype simpler.
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the title
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Putting this up as a draft for reference. Is this a good idea?
If so, I'll split up into backend & frontend PRs.
Fixes LOGS-754