feat(ourlogs): use truncate parameter in page-level logs requests#116009
feat(ourlogs): use truncate parameter in page-level logs requests#116009JoshuaKGoldberg wants to merge 7 commits into
truncate parameter in page-level logs requests#116009Conversation
…w details Sends a viewport-based `truncate` query parameter from the logs query to reduce payload size, and reads the full message from log attributes in the row detail panel so the expanded view always shows untruncated text.
github-actions
Bot
added
the
Scope: Frontend
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.62% |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| organization, | ||
| selection, | ||
| showExploreSimilarSpansLink, | ||
| }) |
There was a problem hiding this comment.
Similar spans uses truncated text
Medium Severity
With list responses truncated via the new truncate query param, the Explore similar spans menu still builds its query from the table cell value, so the cross-events filter can use a shortened message while the detail panel and detail filters use the full text.
Reviewed by Cursor Bugbot for commit 89f5afe. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 3 total unresolved issues (including 2 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 337108b. Configure here.
JoshuaKGoldberg
changed the title
truncate parameter in page-level logs requests
adrianviquez
left a comment
adrianviquez
left a comment
There was a problem hiding this comment.
Small comments but 🚀
2 participants
Sends a viewport-proportional
truncatequery parameter with each page-levelevents/logs API request to reduce payload size. This can reduce response payload size nicely when there are huge log fields, such as -but not limited to-message.The expanded log row detail panel still queries full fields for each log, and prefers those over the potentially truncated ones.
Split out of #115638. #116008 has the corresponding backend changes.
Closes LOGS-817.