Fix flaky benchmark fixture push#18
Merged
Merged
Conversation
git push --all to a freshly initialized bare repo intermittently failed with "Could not read <oid>" / "eof before pack header" because git sends a thin pack whose base objects are absent from the empty remote. Pass --no-thin to always send a complete pack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the intermittent failure of the
Benchmarkjob while seeding thegit_clonefixtures.Context
git push --allto a freshly-initialized bare repo can send a thin pack whose base objects are absent from the empty remote, failing with "Could not read " / "eof before pack header was fully read". The flake is unrelated to PR content and has blocked other PRs. It does not reproduce locally, so it is validated by keeping the Benchmark job green across repeated runs.Changes
fixtures.rs: pass--no-thinto the fixture pushes so a complete pack is always sent.