fix: avoid panic in ParseDuration on trailing whitespace - #279
Closed
bernot-dev wants to merge 1 commit into
Closed
Conversation
Trim leading and trailing whitespace from the input duration string at the start of ParseDuration. This prevents a panic in the parsing loop when strings.TrimLeftFunc(s, unicode.IsSpace) trims a string consisting entirely of trailing spaces into an empty string, which subsequently causes an index out of bounds error when checking s[0]. Added regression test cases covering leading, trailing, and combined spaces around durations (e.g., " 1s ", "1s ", " 1s"). Signed-off-by: Adam Bernot <bernot@google.com>
Member
|
Thank you for reporting this bug. I had in mind to add fuzz tests on all these parsers anyway, so here is an alternate fix to this issue, less intrusive and with fuzz tests so we may safely any similar issue in this parser: #281 Forthcoming PR is to fuzz all parsers, which was a long overdue task. |
Member
|
Superseded by #281. Good catch on the issue, but I won't merge this proposed fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change type
🔧 Bug fix
Short description
Trim leading and trailing whitespace from the input duration string at the start of ParseDuration. This prevents a panic in the parsing loop when strings.TrimLeftFunc(s, unicode.IsSpace) trims a string consisting entirely of trailing spaces into an empty string, which subsequently causes an index out of bounds error when checking s[0]. Added regression test cases covering leading, trailing, and combined spaces around durations (e.g., " 1s ", "1s ", " 1s").
Fixes
N/A
Full description
Checklist