Skip to content

fix: avoid panic in ParseDuration on trailing whitespace #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bernot-dev wants to merge 1 commit into from
+6 −0
Closed

fix: avoid panic in ParseDuration on trailing whitespace #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions duration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ func (d *Duration) UnmarshalText(data []byte) error { // validation is performed
func ParseDuration(s string) (time.Duration, error) {
// NOTE: this code is largely inspired by the standard library.
orig := s
s = strings.TrimSpace(s)
var d uint64
neg := false

Expand Down
5 changes: 5 additions & 0 deletions duration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,11 @@ func TestDurationParser(t *testing.T) {
"1 m45 s": time.Minute + 45*time.Second,
"1m 45s": time.Minute + 45*time.Second,
"1 minute 45 seconds": time.Minute + 45*time.Second,

// leading and trailing spaces
" 1s ": 1 * time.Second,
"1s ": 1 * time.Second,
" 1s": 1 * time.Second,
}

for str, dur := range testcases {
Expand Down