fix(dx12): transition render targets explicitly#259
Closed
besmpl wants to merge 1 commit into
Closed
Conversation
7028791 to
64443c5
Compare
Author
|
Marking this draft while I tighten the state model. Final review found that the current revision still relies on global whole-texture recording-time state, which is not safe for abandoned/reordered command buffers, swapchain PRESENT state, disjoint subresources, or sampled read-only depth. I will either replace it with command-local subresource-aware tracking and focused coverage, or narrow the PR to a correctness shape that can be proven independently. The current branch should not be merged. |
This was referenced Jul 14, 2026
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Track DX12 texture resource state consistently and emit required barriers for:
Textures created by this backend do not opt into ALLOW_SIMULTANEOUS_ACCESS, so render-target and depth states are not implicit promotions. Resolve transitions now use and update actual tracked states instead of hardcoded before-states. Focused tests capture exact transition sequences without calling native FFI.
This extracts and completes the independent DX12 transition fix identified in #253. It contains no counted-draw or prepared-indexed behavior.
Verification