fix(dx12): reconcile resource states across submissions#262
Open
besmpl wants to merge 1 commit into
Open
Conversation
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the narrower but unsound draft #259. The DX12 indirect-argument ABI correction remains isolated in #258.
Why
Recording-time
currentStateis not authoritative when command buffers are recorded independently and submitted later or in a different order. The queue now owns scheduled state, plans non-mutating reconciliation barriers immediately before each command buffer, and commits final state only after execution is handed to D3D12.Verification
CGO_ENABLED=0 go test ./...GOOS=windows GOARCH=amd64 CGO_ENABLED=0 go test -exec=true ./...hal/dx12andhal/dx12/d3d12git diff --checkRemaining validation
This was developed on macOS, so native Windows execution and D3D12 debug-layer validation have not run yet. The PR is draft until that hardware evidence is available.