fix(sqlalchemy-bigquery): resolve ST function type binding bug#17769
Open
ohmayr wants to merge 4 commits into
Open
fix(sqlalchemy-bigquery): resolve ST function type binding bug#17769ohmayr wants to merge 4 commits into
ohmayr wants to merge 4 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the argument type checking logic in _fixup_st_arguments within geography.py by removing a redundant identity check. Additionally, it unskips the test_geoalchemy2_core unit test, updates its expected query string, and introduces a new unit test test_fixup_st_arguments to verify the argument fixup behavior. There are no review comments, so I have no feedback to provide.
ohmayr
force-pushed
the
fix-sqlalchemy-bigquery-geography-bug
branch
2 times, most recently
from
July 20, 2026 08:49
e41196b to
2102681
Compare
ohmayr
force-pushed
the
fix-sqlalchemy-bigquery-geography-bug
branch
from
July 20, 2026 18:33
1ebe446 to
2e4345c
Compare
parthea
reviewed
Jul 20, 2026
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
…pected bind parameter compilation
…hemy2_core unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue in
_fixup_st_argumentswhere argument types were redundantly re-instantiated on every compiler pass due to comparing an instance with a class using is instead ofsinstance. Also adds unit test coverage for_fixup_st_argumentsand unskipstest_geoalchemy2_coreunit test.Fixes #17287 🦕