fix(sqlalchemy-bigquery): wrap string in WKT in geography system tests#17780
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request unskips several GeoAlchemy2 system tests (test_geoalchemy2_core, test_geoalchemy2_orm, and test_geoalchemy2_orm_w_relationship) in packages/sqlalchemy-bigquery/tests/system/test_geography.py. To resolve the previous failures, the spatial string literals in the queries are now wrapped with WKT imported from sqlalchemy_bigquery. There are no review comments, and I have no additional feedback to provide.
parthea
reviewed
Jul 20, 2026
parthea
left a comment
Contributor
There was a problem hiding this comment.
LGTM but holding off on formal approval. Please also update the unit test here
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps spatial string parameters with
WKT(...)in ST_Contains andST_Intersectssystem test queries. This ensures GeoAlchemy2 compilesST_GeogFromText(...)so BigQuery receivesGEOGRAPHYparameters instead of throwing argument type mismatch errors (GEOGRAPHY, STRING). Unskips geography system tests.Towards #17287 🦕