chore(sqlalchemy-bigquery): restore fail_under=100 in .coveragerc and…#17770
Draft
ohmayr wants to merge 3 commits into
Draft
chore(sqlalchemy-bigquery): restore fail_under=100 in .coveragerc and…#17770ohmayr wants to merge 3 commits into
ohmayr wants to merge 3 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the test coverage requirement to 100% in .coveragerc and noxfile.py, omits test directories from coverage, and adds a unit test for the deprecated dbapi method. The review feedback suggests improving the unit test by verifying that calling the deprecated dbapi() method correctly raises a deprecation warning.
Comment on lines
+75
to
+78
| def test_dbapi_deprecated(): | ||
| from sqlalchemy_bigquery.base import BigQueryDialect | ||
|
|
||
| assert BigQueryDialect.dbapi() is BigQueryDialect.import_dbapi() |
Contributor
There was a problem hiding this comment.
Since dbapi() is deprecated, the test should verify that calling it raises a DeprecationWarning (or the appropriate warning category). This ensures that the deprecation warning is active and doesn't regress in the future.
Suggested change
| def test_dbapi_deprecated(): | |
| from sqlalchemy_bigquery.base import BigQueryDialect | |
| assert BigQueryDialect.dbapi() is BigQueryDialect.import_dbapi() | |
| def test_dbapi_deprecated(): | |
| from sqlalchemy_bigquery.base import BigQueryDialect | |
| with pytest.deprecated_call(): | |
| assert BigQueryDialect.dbapi() is BigQueryDialect.import_dbapi() |
…skip geography tests
ohmayr
force-pushed
the
fix-sqlalchemy-bigquery-geography-bug
branch
from
July 20, 2026 08:49
e41196b to
2102681
Compare
ohmayr
force-pushed
the
chore-sqlalchemy-bigquery-coverage-100
branch
from
July 20, 2026 08:50
3757ee2 to
5f11a2e
Compare
…ver session in noxfile
ohmayr
force-pushed
the
fix-sqlalchemy-bigquery-geography-bug
branch
from
July 20, 2026 18:33
1ebe446 to
2e4345c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores coverage for sqlalchemy-bigquery
Towards #17459 🦕