Skip to content

chore(sqlalchemy-bigquery): restore complete coverage #17770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ohmayr wants to merge 7 commits into
base: main
Choose a base branch
from
+9 −1
Open

chore(sqlalchemy-bigquery): restore complete coverage #17770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2102681
fix(sqlalchemy-bigquery): resolve ST function type binding bug and un…
ohmayr Jul 20, 2026
5f11a2e
chore(sqlalchemy-bigquery): restore fail_under=100 in .coveragerc and…
ohmayr Jul 20, 2026
30dbeb1
chore(sqlalchemy-bigquery): remove redundant --fail-under=100 from co…
ohmayr Jul 20, 2026
f5e0991
Merge remote-tracking branch 'origin/main' into chore-sqlalchemy-bigq…
ohmayr Jul 21, 2026
f945090
style(sqlalchemy-bigquery): format test_geography.py with black
ohmayr Jul 21, 2026
f9db540
style(sqlalchemy-bigquery): format test_engine.py with black
ohmayr Jul 21, 2026
66be0a3
chore(sqlalchemy-bigquery): restore Generated by synthtool comment in…
ohmayr Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/sqlalchemy-bigquery/.coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ omit =
sqlalchemy_bigquery/requirements.py

[report]
fail_under = 98
fail_under = 100
show_missing = True
exclude_lines =
# Re-enable the standard pragma
Expand All @@ -37,3 +37,5 @@ omit =
*/core/*.py
*/site-packages/*.py
sqlalchemy_bigquery/requirements.py
tests/*
*/tests/*
6 changes: 6 additions & 0 deletions packages/sqlalchemy-bigquery/tests/unit/test_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,3 +70,9 @@ def test_arraysize_querystring_takes_precedence_over_default(faux_conn, metadata
metadata.create_all(engine)

assert conn.connection.test_data["arraysize"] == arraysize


def test_dbapi_deprecated():
from sqlalchemy_bigquery.base import BigQueryDialect

assert BigQueryDialect.dbapi() is BigQueryDialect.import_dbapi()
Comment thread
ohmayr marked this conversation as resolved.
Loading