chore(django-spanner): restore fail_under=100 in .coveragerc#17772
Open
ohmayr wants to merge 8 commits into
Open
chore(django-spanner): restore fail_under=100 in .coveragerc#17772ohmayr wants to merge 8 commits into
ohmayr wants to merge 8 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the coverage configuration in .coveragerc by increasing the fail_under threshold to 100% and omitting test directories. It also configures coverage for the mockserver session in noxfile.py and adjusts coverage failure thresholds. The reviewer pointed out that specifying --cov=tests.mockserver_tests in noxfile.py is redundant since test directories are already omitted in .coveragerc, and suggested removing this argument.
Comment on lines
+158
to
+159
| "--cov=django_spanner", | ||
| "--cov=tests.mockserver_tests", |
Contributor
There was a problem hiding this comment.
Since tests/* and */tests/* are explicitly omitted in .coveragerc, specifying --cov=tests.mockserver_tests here is redundant and will be ignored by coverage. It is cleaner to remove this argument.
Suggested change
| "--cov=django_spanner", | |
| "--cov=tests.mockserver_tests", | |
| "--cov=django_spanner", |
…for 100% CI coverage
…s in unit session for 100% coverage
…unit test coverage threshold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix coverage for django-spanner
Towards #17459 🦕