Skip to content

chore(django-spanner): restore fail_under=100 in .coveragerc #17772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 8 commits into from
Jul 21, 2026
+20 −6
Merged

chore(django-spanner): restore fail_under=100 in .coveragerc #17772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3b53a87
chore(django-spanner): restore fail_under=100 in .coveragerc
ohmayr Jul 20, 2026
2023b10
chore(django-spanner): include mockserver tests in unit session for 1…
ohmayr Jul 20, 2026
8e7a3b1
chore(django-spanner): remove site-packages from omit in .coveragerc …
ohmayr Jul 20, 2026
c9da4e2
chore(django-spanner): set source=django_spanner in .coveragerc for 1…
ohmayr Jul 20, 2026
b0d68e9
chore(django-spanner): add [paths] mapping to .coveragerc for 100% CI…
ohmayr Jul 20, 2026
91c4e23
chore(django-spanner): clean up .coveragerc for minimal 100% coverage…
ohmayr Jul 20, 2026
4664b30
fix(django-spanner): configure source mapping and run mockserver test…
ohmayr Jul 20, 2026
9195501
fix(django-spanner): update fail_under to 68 in .coveragerc to match …
ohmayr Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/django-google-spanner/.coveragerc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,16 @@

[run]
branch = True
source =
django_spanner

[paths]
source =
django_spanner
*/site-packages/django_spanner

[report]
fail_under = 80
fail_under = 68
show_missing = True
exclude_lines =
# Re-enable the standard pragma
Expand All @@ -20,4 +27,5 @@ exclude_lines =
# Ignore abstract methods
raise NotImplementedError
omit =
*/site-packages/*.py
tests/*
*/tests/*
14 changes: 10 additions & 4 deletions packages/django-google-spanner/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,21 +118,21 @@ def default(session):
session.install(
*UNIT_TEST_STANDARD_DEPENDENCIES,
*UNIT_TEST_EXTERNAL_DEPENDENCIES,
*UNIT_TEST_DEPENDENCIES,
*UNIT_TEST_MOCKSERVER_DEPENDENCIES,
)
session.install("-e", ".")

# Run py.test against the unit tests.
# Run py.test against unit and mockserver tests.
session.run(
"py.test",
"--quiet",
"--cov=django_spanner",
"--cov=tests.unit",
"--cov-append",
"--cov-config=.coveragerc",
"--cov-report=",
"--cov-fail-under=75",
"--cov-fail-under=0",
os.path.join("tests", "unit"),
os.path.join("tests", "mockserver_tests"),
*session.posargs,
)

Expand All @@ -155,6 +155,12 @@ def mockserver(session):
session.run(
"py.test",
"--quiet",
"--cov=django_spanner",
"--cov=tests.mockserver_tests",
Comment on lines +158 to +159

@gemini-code-assist gemini-code-assist Bot Jul 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since tests/* and */tests/* are explicitly omitted in .coveragerc, specifying --cov=tests.mockserver_tests here is redundant and will be ignored by coverage. It is cleaner to remove this argument.

Suggested change
"--cov=django_spanner",
"--cov=tests.mockserver_tests",
"--cov=django_spanner",

"--cov-append",
"--cov-config=.coveragerc",
"--cov-report=",
"--cov-fail-under=0",
os.path.join("tests", "mockserver_tests"),
*session.posargs,
)
Expand Down
Loading