Repository navigation
Give the modifications an applicability for the tag of a new root network #940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
e52e2d1
Make root network applicabilities explicit
flomillot 87de498
Merge remote-tracking branch 'origin/main' into refactor/explicit-roo…
flomillot 44f111d
Give the modifications an applicability for the tag of a new root net…
flomillot b25b25d
Set the default applicabilities of the shared modifications in Java
flomillot 6ba2413
Merge remote-tracking branch 'origin/main' into HEAD
flomillot c8bc6a5
Merge remote-tracking branch 'origin/main' into HEAD
flomillot 91d7213
Pass the root network tags in the tests coming from main
flomillot f118575
Merge remote-tracking branch 'origin/refactor/explicit-root-network-a…
flomillot bf9f82e
Add the root network tag applicabilities in Java
flomillot 4dee0f2
Remove comments restating the code
flomillot f96feb5
Merge remote-tracking branch 'origin/refactor/explicit-root-network-a…
flomillot b4bb64f
Remove a comment restating the test
flomillot cff114f
Merge remote-tracking branch 'origin/main' into HEAD
flomillot 6e8b308
Merge remote-tracking branch 'origin/main' into feat/new-root-network…
flomillot f4fea8d
Remove the test duplicated by the merge of main
flomillot f87f9d5
Merge remote-tracking branch 'origin/main' into HEAD
flomillot fa5f177
Merge remote-tracking branch 'origin/main' into HEAD
flomillot cd18db3
Merge branch 'main' into feat/new-root-network-applicability
etiennehomer 6b94910
"Remove redundant comment in NetworkModificationRepository"
flomillot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these first lines are the same as in renameRootNetworkTag
=> create small private function to avoid fixing this in two places lates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest something because I don't see how to make it without adding more code ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can create record hold both result of what you called ownedUuids and sharedTreesUuids ...
never mind it can be done next time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but it add more codes, create a record used only once, and don't make it clearer IMO, unless I haven't understand